This repository was archived by the owner on Aug 1, 2021. It is now read-only.
add links for depedencies, extra licenses, and output as file#20
Open
mayel wants to merge 4 commits intounnawut:masterfrom
Open
add links for depedencies, extra licenses, and output as file#20mayel wants to merge 4 commits intounnawut:masterfrom
mayel wants to merge 4 commits intounnawut:masterfrom
Conversation
Pull Request Test Coverage Report for Build 60
💛 - Coveralls |
unnawut
reviewed
Feb 21, 2021
Owner
unnawut
left a comment
unnawut
left a comment
There was a problem hiding this comment.
Thank you! I made a few comments. Feel free to counter me on any of them. :)
| Map.put(license, :license, conclusion) | ||
| end | ||
|
|
||
| defp guess(file, ""), do: guess(file, nil) |
Owner
There was a problem hiding this comment.
If I remember correctly, there shouldn't be any case where the 2nd argument is an empty string. So I think if it falls into this case we should fix the root cause than handling it here.
Author
There was a problem hiding this comment.
I have a case of a dependency with no license which results in an empty license column in the final rather than "Undefined" if this line is present.
| end | ||
|
|
||
| defp render(rows, opts) do | ||
| if Keyword.get(opts, :only_license), |
Owner
There was a problem hiding this comment.
I think the short hand if: ..., do: ..., else: ... are discouraged for multi-line conditionals per the popular code style.
Author
|
How does it look now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hope others find this useful... Also tweaked the logic so as to properly recognise at least all the deps in my project :)